WIP: Sqlite migration and foreignKey support #612
Conversation
…sqlite' in the 'bookstore' database section. (for testing purposes) This is in WIP. Next step is that travis-ci uses several environments where we test sqlite/pgsql/mysql, not as currently where the most tests are against mysql. This generated a couple of issues since some tests got the ($this->con) connection from the wrong database. Also fixed a bunch of errors with the new SQLite stuff.
| * @param ForeignKey $fk | ||
| */ | ||
| public function removeForeignKey(ForeignKey $fk){ | ||
| $idx = array_search($fk, $this->foreignKeys); |
There was a problem hiding this comment.
use isset instead because its a lot faster
There was a problem hiding this comment.
It's about removing the FK, not checking.
|
sorry for the early feedback, I just recognized its an WIP... |
|
Has there been any progress on this? I have a project which I'd like to move to a fatter model but whether I wait and switch to Propel or just jerry rig something on top of my existing solution will depend on how likely this is to be ready within the next few months. |
|
You are welcome to provide the remaing changes for this PR. I don't know if @marcj will have time for this |
|
Given how little time I have, the "within the next few months" may be a limit imposed by when I have time to migrate to Propel or even just make changes to my existing database code. As much as I'd love to help, there's no way I have time to grow familiar enough with the Propel codebase to contribute a patch in the near future. However, in the longer term (say... July, maybe?), it's a possibility if you or someone else familiar with the project can point me to a crash course in how the Propel codebase is laid out, how comprehensive the unit tests are, what standards need to be met for this patch to get accepted (including what extra unit tests I might have to write), etc. |
|
Sure. Just give us a ping when you have time |
|
I'll close this PR soon and will integrate it in Propel2. |
|
In three days, it'll have been two months since you said "soon". I'd like to start using Propel2 on an SQLite-backed project before my vacation ends. Did you forget or is there some hold-up I might be able to handle for you? |
|
Unfortunately, I'm not able to work on this issue, since I'm working on another big project for the next weeks. But I guess I need this PR as well in that project (but in Propel2). However, this PR is 'nearly' done, so it shouldn't be much work to complete it. |
|
I've implemented those features in Propel2: propelorm/Propel2#433 |
Just need the PR id in another ticket. Maybe it's done in a few days.